feat: add Log Analytics workspace and diagnostics for deployment infrastructure #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainer - Added a Log Analytics workspace resource to monitor deployment activities. - Implemented diagnostic settings for the deployment container and blob service. - Updated variables for log analytics retention and included options for enabling/disabling log analytics. - Adjusted scale capacity for cognitive deployments to avoid exceeding quotas. - Enhanced troubleshooting documentation for deployment errors and quota issues.
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the infrastructure monitoring and deployment capabilities by adding centralized Log Analytics diagnostics, improving resource management, and strengthening CI/CD workflows. The changes introduce comprehensive logging for Azure services while maintaining security best practices and deployment reliability.
Key changes:
- Added Log Analytics workspace provisioning with configurable retention and diagnostic settings for storage services
- Refactored resource group management into a dedicated file with improved logic for existing vs. new resource groups
- Enhanced deployment scripts with external file organization and additional environment variables for better maintainability
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/variables.tf | Added Log Analytics configuration variables with validation and reduced OpenAI default capacity |
| infra/main.tf | Removed duplicate resource group logic in favor of dedicated file |
| infra/main.search_configuration.tf | Added comprehensive diagnostic settings for storage services and externalized deployment script |
| infra/main.resource_group.tf | New dedicated file for resource group management with improved conditional logic |
| infra/main.naming.tf | Added deterministic random seed and Log Analytics workspace to naming convention |
| infra/main.app_insights.tf | Added Log Analytics workspace resource with conditional provisioning |
| docs/troubleshooting.md | New troubleshooting guide for common deployment issues |
| docs/cicd.md | Minor documentation formatting fix |
| docs/app_registration_setup.md | Updated authentication command with device code flag |
| .github/workflows/azure-dev.yml | Enhanced workflow to support PR triggers and improved .NET SDK installation |
…loading functionality
…sioning, and create private endpoint for Azure OpenAI service
…dd triggers for readiness check
mattdot
requested changes
Oct 14, 2025
…ng and logging capabilities
…nd remove unused categories
mattdot
previously approved these changes
Oct 15, 2025
mattdot
approved these changes
Oct 15, 2025
ianjensenisme
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to Azure resource management, diagnostics, and deployment automation, with improvements to infrastructure code, workflow automation, and documentation. The most significant changes include support for Log Analytics diagnostics, improved resource group management logic, updates to deployment scripts, and workflow reliability improvements.
Infrastructure and Diagnostics Enhancements:
azurerm_log_analytics_workspace) and enabling diagnostic logging for storage account, blob, and file services, gated by theinclude_log_analyticsvariable. This allows for more robust monitoring and auditing of deployment artifacts and operations. [1] [2]Resource Group Management:
main.resource_group.tf), supporting both creation of new resource groups and usage of existing ones, with appropriate data source validation and output locals.Deployment Automation and Scripts:
configure-search-index.sh) for better maintainability and modularity. Added additional environment variables for improved parameterization. [1] [2] [3]Workflow Automation Improvements:
main, updated action versions for reliability, and changed .NET SDK installation to use a script for better compatibility with self-hosted runners. [1] [2] [3] [4]Documentation Updates:
troubleshooting.md) with tips for quota errors, private endpoint provisioning, and using GitHub Copilot for deployment issues.