Skip to content

Conversation

@mattdot
Copy link
Collaborator

@mattdot mattdot commented Oct 17, 2025

This pull request makes a minor update to the infra/main.tfvars.json configuration file, improving its robustness by setting default values for certain variables. This change helps prevent errors when environment variables are unset.

  • Configuration resilience:
    • Updated resource_share_user and tags to default to null if their respective environment variables are not set, ensuring smoother deployments and fewer runtime errors.

Related Issue(s)

Link to the issue(s) this PR is related to. Prefix with "Fixes" or "Resolves". Every PR must be associated with an Issue

Resolves #311

@mattdot mattdot self-assigned this Oct 17, 2025
@mattdot mattdot marked this pull request as ready for review October 17, 2025 06:34
@mattdot mattdot requested a review from a team as a code owner October 17, 2025 06:34
Copilot AI review requested due to automatic review settings October 17, 2025 06:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures safer defaults in infra/main.tfvars.json to prevent errors when certain environment variables are unset.

  • Adds null fallbacks for resource_share_user and tags.
  • Adjusts variable interpolation to include bash-style default syntax.

Copy link
Collaborator

@cmaclaughlin cmaclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattdot mattdot merged commit ee9d0b1 into main Oct 17, 2025
12 of 13 checks passed
@mattdot mattdot deleted the json-defaults branch October 17, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Azure 'tags' defaulting to invalid type in main.tfvars when running local deployment

4 participants