Update sign in sample to not use hybrid flow (implicit id token) #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sign-in sample to use the authorization code flow instead of the hybrid flow with implicit ID tokens, following modern OAuth 2.0 security best practices.
- Removes the requirement for implicit ID token grant in Azure AD app registration
- Adds client credentials configuration to enable proper token exchange
- Updates authentication setup to use authorization code flow with token acquisition capabilities
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| appsettings.json | Adds ClientCredentials configuration section with client secret setup |
| Startup.cs | Updates authentication to enable token acquisition and adds in-memory token cache |
| README.md | Removes implicit grant instructions and adds client secret setup documentation |
| services.AddAuthentication(OpenIdConnectDefaults.AuthenticationScheme) | ||
| .AddMicrosoftIdentityWebApp(options => Configuration.Bind("AzureAd", options)); | ||
| .AddMicrosoftIdentityWebApp(options => Configuration.Bind("AzureAd", options)) | ||
| .EnableTokenAcquisitionToCallDownstreamApi() // This is needed to exchange the authorization code for an ID Token |
There was a problem hiding this comment.
The comment is technically inaccurate. EnableTokenAcquisitionToCallDownstreamApi() enables token acquisition for calling downstream APIs, not specifically for exchanging authorization code for ID tokens. The comment should be updated to reflect the actual purpose.
Suggested change
| .EnableTokenAcquisitionToCallDownstreamApi() // This is needed to exchange the authorization code for an ID Token | |
| .EnableTokenAcquisitionToCallDownstreamApi() // Enables token acquisition for calling downstream APIs |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove implicit id token