Skip to content

Conversation

@pamelafox
Copy link
Contributor

Purpose

This pull request updates file handling in the summarize_results and diff_directories functions within src/evaltools/review/utils.py to explicitly specify UTF-8 encoding. This ensures consistent behavior when reading files, particularly in environments with non-default encodings like Windows.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Run diff and summary

@pamelafox pamelafox merged commit 7c1189f into main Apr 30, 2025
13 of 17 checks passed
@pamelafox pamelafox deleted the addencoding branch April 30, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants