Skip to content

Fix: Use searchable field instead of identifier in Azure Search #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Use searchable field instead of identifier in Azure Search #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/backend/ragtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ async def _search_tool(
semantic_configuration_name=semantic_configuration,
top=5,
vector_queries=vector_queries,
search_fields=[content_field],
select=", ".join([identifier_field, content_field])
)
result = ""
Expand All @@ -86,7 +87,7 @@ async def _report_grounding_tool(search_client: SearchClient, identifier_field:
# Use search instead of filter to align with how detailt integrated vectorization indexes
# are generated, where chunk_id is searchable with a keyword tokenizer, not filterable
search_results = await search_client.search(search_text=list,
search_fields=[identifier_field],
search_fields=[content_field],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a functional difference, to search the content field for the grounding sources, how does this work? It's sending in a query like "4c1968ac98f3_aHR0cHM6Ly9zdGVqN2o0ZzJ6cG96ZXMuYmxvYi5jb3JlLndpbmRvd3MubmV0L2NvbnRlbnQvcm9sZV9saWJyYXJ5LnBkZg2_pages_36" which wouldnt be in the content field.

select=[identifier_field, title_field, content_field],
top=len(sources),
query_type="full")
Expand Down