Skip to content

Update rtmt.py - pop gives the error when there are two message in the queue #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −2
Open

Update rtmt.py - pop gives the error when there are two message in the queue #73

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80ba6a7
Update rtmt.py - pop gives the error when there are two message in th…
pmuralikrishna111 Jan 22, 2025
7ec7982
Merge branch 'main' into main
pmuralikrishna111 Feb 21, 2025
aced8ab
Merge branch 'main' into main
pmuralikrishna111 Apr 2, 2025
e85ce76
Update rtmt.py - output_len variable declaration
pmuralikrishna111 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/backend/rtmt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,15 @@ async def _process_message_to_client(self, msg: str, client_ws: web.WebSocketRes
})
if "response" in message:
replace = False
for i, output in enumerate(reversed(message["response"]["output"])):
# Get the original list length
output_len = len(message["response"]["output"])

# Iterate in reverse while calculating the correct index
for reverse_index, output in enumerate(reversed(message["response"]["output"])):
if output["type"] == "function_call":
message["response"]["output"].pop(i)
original_index = output_len - 1 - reverse_index # Map reversed index to the original
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output_len ? where is it declared and initialized ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reviewing my PR. Apologies missed to add the declaration earlier. Its now resolved. and updated my PR.

print("Len of message[response][output]:", output_len, ", output:", message["response"]["output"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmuralikrishna111 Remove print(), I assume that was for debugging

Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug print statement should be removed before merging to production. Consider using proper logging instead of print statements.

Suggested change
print("Len of message[response][output]:", output_len, ", output:", message["response"]["output"])
logger.debug("Len of message[response][output]: %d, output: %s", output_len, message["response"]["output"])

Copilot uses AI. Check for mistakes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say to just remove it entirely.

message["response"]["output"].pop(original_index)
replace = True
if replace:
updated_message = json.dumps(message)
Expand Down