Skip to content

Conversation

saravana87
Copy link
Contributor

@saravana87 saravana87 commented Sep 24, 2024

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

I am adding the CSV parser python code.
it works with basic CSV files.
updating the csv parser code and importing the CsvParser class
@saravana87
Copy link
Contributor Author

@microsoft-github-policy-service agree

@pamelafox
Copy link
Collaborator

Hi @saravana87, thanks for this PR! This looks useful, having a local CSV parser. If this is an intentional PR for merging into main, can you edit the title and description to describe it fully?

@pamelafox
Copy link
Collaborator

Can you also add a test? You can copy test_htmlparser.py and adapt that to CSV examples instead. Thank you!

@saravana87
Copy link
Contributor Author

Can you also add a test? You can copy test_htmlparser.py and adapt that to CSV examples instead. Thank you!

Thank you. I will work on this and let you know.

@saravana87
Copy link
Contributor Author

Can you also add a test? You can copy test_htmlparser.py and adapt that to CSV examples instead. Thank you!

I have added the test_csvparser.py
https://github.com/saravana87/azure-search-openai-demo/blob/main/tests/test_csvparser.py

@saravana87 saravana87 changed the title Dev01 Adding CSV parser feature Sep 26, 2024
@pamelafox
Copy link
Collaborator

@saravana87 Great, can you push that to this branch? That seems to be in your main branch, not dev01.

@pamelafox
Copy link
Collaborator

It looks like your file also needs formatting, see guide to using ruff in https://github.com/Azure-Samples/azure-search-openai-demo/blob/main/CONTRIBUTING.md#submit-pr

@saravana87
Copy link
Contributor Author

@saravana87 Great, can you push that to this branch? That seems to be in your main branch, not dev01.

Yes, I have formatted the files. Let me close this pull request and I will raise another pull request from the Main branch.

@saravana87 saravana87 closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants