-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix scrolling bar issue for long content in chat UI #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
limit .chatContainer height and expand chatMessageStream
@BetterAndBetterII - you beat me to it :) thank you for this! I will test later tomorrow and confirm. Appreciate your fix! Cheers |
@BetterAndBetterII - thank you and it works nicely on mobile too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The side panel (Citation tab, etc.) area is getting smaller. How about allowing it to be resized?
@bnodir Does the latest change address your desire for resizability? |
yeah
…---Original---
From: "Pamela ***@***.***>
Date: Fri, Oct 18, 2024 17:27 PM
To: ***@***.***>;
Cc: "Yuzhong ***@***.******@***.***>;
Subject: Re: [Azure-Samples/azure-search-openai-demo] fix scrolling bar issue(PR #2044)
@bnodir Does the latest change address your desire for resizability?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Not quite.
@BetterAndBetterII - I noticed you added |
I'm very sorry, I forgot what you said when I was testing it. I checked it again and you are right. The analysis panel also has the same multiple scroll bars issue, so I adjusted the maximum height limit. The adjustable range of the chat container is also limited. |
@BetterAndBetterII - I'm not a CSS expert, but it seems to be alright when I tested it quickly. Thanks for fixing it! |
Thank you! |
limit .chatContainer height and expand chatMessageStream
Purpose
fix #2002
prevent the outside scrolling bar by limiting the total height.
extented the chatMessageStream to width 100%, and use padding to constrain the chat messages in center. (in order to allow user to scroll in wide range)
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.