Skip to content

Conversation

EMjetrot
Copy link
Contributor

@EMjetrot EMjetrot commented Nov 4, 2024

Purpose

This update introduces Danish language support in the application, including translations of the user interface and labels into Danish by a native speaker. This enhancement provides a more accessible experience for Danish-speaking users.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

Screenshots

frontend-chat frontend-chat-settings frontend-qa frontend-qa-settings

@EMjetrot
Copy link
Contributor Author

EMjetrot commented Nov 4, 2024

@microsoft-github-policy-service agree

@pamelafox
Copy link
Collaborator

Thanks for all the screenshots! I'll ask same questions I asked on the recent Dutch PR:

I assume that you wrote these translations yourself, i.e. you're a native Danish speaker?

Will you be available to translate strings in the future, i.e. can I tag you on PRs that add new strings? I don't know if I have any Danish speaking colleagues, so we need to make sure we have a strategy to continue support for da-DK.

Thanks!

@EMjetrot
Copy link
Contributor Author

EMjetrot commented Nov 4, 2024

@pamelafox Yes, I am a native Danish speaker and feel free to tag me on PRs that add new Danish strings if needed :)

@pamelafox pamelafox merged commit 298e457 into Azure-Samples:main Nov 4, 2024
10 checks passed
@pamelafox
Copy link
Collaborator

Great, merged! Thank you!

@EMjetrot EMjetrot deleted the feat/translation-danish branch November 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants