Skip to content

let env var overrule .dot env setting #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

let env var overrule .dot env setting #2136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887598b
let env var overrule .dot env setting
cforce Nov 10, 2024
86540e8
Load azd env vars variable
pamelafox Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
"env": {
"QUART_APP": "main:app",
"QUART_ENV": "development",
"QUART_DEBUG": "0"
"QUART_DEBUG": "0",
// Set this to "no-override" if you want env vars here to override AZD env vars
"LOADING_MODE_FOR_AZD_ENV_VARS": "override"
},
"args": [
"run",
Expand Down
10 changes: 8 additions & 2 deletions app/backend/load_azd_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
import logging
import os
import subprocess

from dotenv import load_dotenv
Expand All @@ -19,5 +20,10 @@ def load_azd_env():
env_file_path = entry["DotEnvPath"]
if not env_file_path:
raise Exception("No default azd env file found")
logger.info(f"Loading azd env from {env_file_path}")
load_dotenv(env_file_path, override=True)
loading_mode = os.getenv("LOADING_MODE_FOR_AZD_ENV_VARS") or "override"
if loading_mode == "no-override":
logger.info("Loading azd env from %s, but not overriding existing environment variables", env_file_path)
load_dotenv(env_file_path, override=False)
else:
logger.info("Loading azd env from %s, which may override existing environment variables", env_file_path)
load_dotenv(env_file_path, override=True)