Skip to content

[Bugfix] The "send" button for chat should be enabled for logged in users #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[Bugfix] The "send" button for chat should be enabled for logged in users #2202

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a389c2c
Update QuestionInput.tsx
jeannotdamoiseaux Nov 29, 2024
c074a64
Add additional boolean for disabling sendquest
pamelafox Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/frontend/src/components/QuestionInput/QuestionInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export const QuestionInput = ({ onSend, disabled, placeholder, clearOnSend, init
};

const disableRequiredAccessControl = requireLogin && !loggedIn;
const sendQuestionDisabled = disabled || !question.trim() || requireLogin;
const sendQuestionDisabled = disabled || !question.trim();
Copy link
Collaborator

@pamelafox pamelafox Dec 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I wonder if it would make more sense to have || disableRequiredAccessControl? Would that also resolve the bug, since it should only be true when not logged in.

It's not a difference security-wise, since a logged out user will fail the authentication check on the server-side, but it'd make sense visually/for screen readers, I think.


if (disableRequiredAccessControl) {
placeholder = "Please login to continue...";
Expand Down