Skip to content

Replace sparkle with app logo that's easier to replace #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Replace sparkle with app logo that's easier to replace #2299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/frontend/src/assets/applogo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion app/frontend/src/assets/github.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/frontend/src/assets/search.svg
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions app/frontend/src/pages/chat/Chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { useRef, useState, useEffect, useContext } from "react";
import { useTranslation } from "react-i18next";
import { Helmet } from "react-helmet-async";
import { Panel, DefaultButton } from "@fluentui/react";
import { SparkleFilled } from "@fluentui/react-icons";
import readNDJSONStream from "ndjson-readablestream";

import appLogo from "../../assets/applogo.svg";
import styles from "./Chat.module.css";

import {
Expand Down Expand Up @@ -370,7 +370,8 @@ const Chat = () => {
<div className={styles.chatContainer}>
{!lastQuestionRef.current ? (
<div className={styles.chatEmptyState}>
<SparkleFilled fontSize={"120px"} primaryFill={"rgba(115, 118, 225, 1)"} aria-hidden="true" aria-label="Chat logo" />
<img src={appLogo} alt="App logo" width="120" height="120" />

<h1 className={styles.chatEmptyStateTitle}>{t("chatEmptyStateTitle")}</h1>
<h2 className={styles.chatEmptyStateSubtitle}>{t("chatEmptyStateSubtitle")}</h2>
{showLanguagePicker && <LanguagePicker onLanguageChange={newLang => i18n.changeLanguage(newLang)} />}
Expand Down
13 changes: 0 additions & 13 deletions app/frontend/src/pages/layout/Layout.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,6 @@
display: none;
}

.microsoftLogo,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the files and CSS rules because they're no longer used, these were removed in @zedhaque's PR a while ago that improved responsive design.

.githubLogo {
display: none;
}

.menuToggle {
display: block;
background: none;
Expand Down Expand Up @@ -143,14 +138,6 @@
vertical-align: middle;
}

.githubLogo,
.microsoftLogo {
height: 1.25rem;
font-weight: 600;
display: inline-block;
vertical-align: middle;
}

.menuToggle {
display: none;
}
Expand Down
Loading