Skip to content

Conversation

pamelafox
Copy link
Collaborator

Purpose

Fixes #2328 due to pending version deprecation

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[X] No - quality should be better/same

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

N/A

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox pamelafox marked this pull request as ready for review February 6, 2025 01:06
@pamelafox pamelafox requested a review from tonybaloney February 6, 2025 01:07
@tonybaloney tonybaloney merged commit d277675 into Azure-Samples:main Feb 6, 2025
18 checks passed
vijayreddysamula added a commit to vijayreddysamula/azure-search-openai-demo that referenced this pull request Feb 9, 2025
dfl-aeb pushed a commit to dfl-aeb/azure-search-openai-demo that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change 0613 to 0125 for gpt-35-turbo
2 participants