-
Notifications
You must be signed in to change notification settings - Fork 5k
Add query rewriting option #2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query rewriting option #2437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for query rewriting in the search functionality by upgrading the Search SDK and integrating the new AZURE_SEARCH_QUERY_REWRITING environment variable. Key changes include updates to documentation, test coverage for query rewriting, and the necessary modifications in both backend and frontend code to propagate the new query rewriting option.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
docs/deploy_features.md | Added documentation for enabling query rewriting (spelling typo in env variable). |
tests/test_chatapproach.py | Added test to validate query rewriting behavior. |
app/frontend/src/components/Settings/Settings.tsx | Updated settings to allow toggling query rewriting. |
app/backend/app.py, config.py | Integrated new config variable for query rewriting. |
app/frontend/src/api/models.ts, various pages | Propagated query rewriting option through API models and page states. |
app/backend/approaches/* | Updated search methods to pass through the query rewriting flag. |
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test it fully since I dont have a search service in the right region, but its now working for existing environments, so that's good. Code looks good.
Purpose
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change