-
Notifications
You must be signed in to change notification settings - Fork 5k
Raise minimum node version #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them.
|
1 similar comment
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR raises the minimum supported Node.js version from 18 to 20 and updates the test workflow to run against both Node 20 and Node 22.
- Update README.md to reflect the new Node.js version requirement
- Modify the GitHub Actions workflow to include a matrix for Node.js testing
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
README.md | Updated documentation to indicate Node.js 20+ requirement |
.github/workflows/python-test.yaml | Extended test matrix to include Node.js 20 and 22, and updated the setup-node step accordingly |
Files not reviewed (3)
- .devcontainer/devcontainer.json: Language not supported
- app/frontend/.nvmrc: Language not supported
- app/frontend/package.json: Language not supported
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them.
|
Purpose
Current LTS version of Node is 22. This uses 22 for nvmrc and devcontainer.json, but runs tests against both 22 and 20, in case of developers running LTS-1.
Recommendation came from colleagues.
Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.