Skip to content

Replaced the "or" condition with "and" condition . "||"->"&&" to solve "CHAT-HISTORY-BUTTON" visiblity bug . #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SwamiDewalkarVWITS
Copy link

Purpose

Replaced the "or" condition with "and" condition . "||"->"&&" to solve "CHAT-HISTORY-BUTTON" visiblity bug .

even if showChatHistoryBrowser is False & showChatHistoryCosmos is True , the fronted was showing the "open-chat-history-button"

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[✓] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[✓] No

Type of change

[✓] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • [✓] The current tests all pass (python -m pytest).
  • [✓] I added tests that prove my fix is effective or that my feature works
  • [✓] I ran python -m pytest --cov to verify 100% coverage of added lines
  • [✓] I ran python -m mypy to check for type errors
  • [✓] I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox
Copy link
Collaborator

Hm, I'm confused. If showChatHistoryCosmos is true, wouldn't you want to see the chat history? We should be showing the chat history if the app is either using chat history with CosmosDB for logged in users, or if the app is using chat history with indexedDB for non-logged in users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants