Skip to content

Conversation

michuhu
Copy link
Contributor

@michuhu michuhu commented Sep 12, 2025

changes in i18n config
modified the docs to reflect the chagnes

Purpose

Adds locales for polish language

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[x] Other... Please describe: adds locales 

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

changes in i18n config
modified the docs to reflect the chagnes
@michuhu
Copy link
Contributor Author

michuhu commented Sep 12, 2025

@microsoft-github-policy-service agree

@pamelafox
Copy link
Collaborator

@michuhu Thanks for the PR! I assume you are a native Polish speaker? Could you attach a screenshot that shows the UI translated in Polish?

@pamelafox
Copy link
Collaborator

Hm, i18n-check thinks there are 16 missing keys in the Polish file

@michuhu
Copy link
Contributor Author

michuhu commented Sep 13, 2025

@michuhu Thanks for the PR! I assume you are a native Polish speaker? Could you attach a screenshot that shows the UI translated in Polish?

Hello @pamelafox yes, I'm native Polish speaker, Poland born and raised :)
I see where the missing keys came from. There was your commit 2 weeks ago, that changed the keys, e.g.:

gpt4vExamples -> multimodalExamples
reasoningEffortOptions -> added "minilmal"
useGPT4V -> llmInputs
gpt4VInput -> llmInputsOptions 

I've missed those changes while working on the translation. Now, it's fixed and should be fine. Thank you for careful attention.

Here are the screens of working version.
1

2

@pamelafox
Copy link
Collaborator

@michuhu Thank you so much! All the checks have passed, screenshots look great. Merging now.

@pamelafox pamelafox merged commit 56863b0 into Azure-Samples:main Sep 16, 2025
26 checks passed
@michuhu
Copy link
Contributor Author

michuhu commented Sep 16, 2025

Yay! Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants