-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add Python 3.14 support and drop Python 3.9 #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
970720f
8253cc0
5719d42
98459e5
ac5857a
13ab999
73c9fd8
ebac3b3
2b5cec5
ed0046a
a50bd90
5d93bf3
a594f3f
64a3484
741c6a1
3b3ff02
bb1254b
8cc2ff7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM python:3.11-bullseye | ||
| FROM python:3.13-bookworm | ||
|
|
||
| WORKDIR /app | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |||||
| from abc import ABC | ||||||
| from collections.abc import AsyncGenerator, Awaitable | ||||||
| from dataclasses import dataclass, field | ||||||
| from typing import Any, Optional, TypedDict, Union, cast | ||||||
| from typing import Any, Optional, TypedDict, cast | ||||||
|
|
||||||
| from azure.search.documents.agent.aio import KnowledgeAgentRetrievalClient | ||||||
| from azure.search.documents.agent.models import ( | ||||||
|
|
@@ -190,7 +190,7 @@ def build_filter(self, overrides: dict[str, Any]) -> Optional[str]: | |||||
| filters.append("category eq '{}'".format(include_category.replace("'", "''"))) | ||||||
| if exclude_category: | ||||||
| filters.append("category ne '{}'".format(exclude_category.replace("'", "''"))) | ||||||
| return None if len(filters) == 0 else " and ".join(filters) | ||||||
| return None if not filters else " and ".join(filters) | ||||||
|
||||||
| return None if not filters else " and ".join(filters) | |
| return None if len(filters) == 0 else " and ".join(filters) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that ruff did it, so it must be part of ruff check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, we can use | syntax!