Sushama/eng 1135 ai master engineer production readiness audit and completion #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple prompts for engineering domain
…stead of product management
…s-on-example-app-ui ENG-1006: Branding Pass on UI
…info, single/batch embedding, and performance tests
…ding-model-to-use-patentsberta ENG-1036: Update Embedding Model to use PatentsBERTa
Adds core agent functionality, configuration, handlers, and services for M365 integration. Co-authored-by: me <[email protected]>
This commit replaces the direct integration with Azure OpenAI and Azure AI Search with calls to the existing backend API. This reduces code duplication and centralizes RAG logic. The `.env.example` and `README.md` files have been updated to reflect this change, and the `rag_service.py` has been modified to use `aiohttp` for making HTTP requests to the backend. Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
…-integration-909b Plan M365 agents SDK integration
This commit introduces Teams-specific handlers and adapters to enhance the bot's integration with Microsoft Teams. It includes support for adaptive cards, suggested actions, and improved response formatting tailored for the Teams environment. Co-authored-by: me <[email protected]>
Co-authored-by: me <[email protected]>
- Update welcome and help cards to use AGENT_NAME and AGENT_DESCRIPTION env vars - Default to 'Structural Engineering Assistant' with engineering-focused content - Update suggested actions to be engineering-specific (Analyze Drawing, Review Calculation, etc.) - Add structural engineering examples and capabilities - Update test cases to match new environment-driven content - All tests passing with structural engineering focus
…ering - Update fallback welcome message to use environment variables - Update fallback help message to use environment variables - Update main help response text to use environment variables - All text now defaults to structural engineering focus - Maintains consistency across all UI components - All tests passing
Co-authored-by: me <[email protected]>
- Create constants/teams_text.py with all Teams UI text strings - Add TeamsTextConstants class with environment-driven text formatting - Refactor TeamsComponents to use constants instead of hardcoded strings - Refactor TeamsResponseAdapter to use constants for all text - Refactor TeamsHandler action responses to use constants - Add helper methods for dynamic text formatting with f-strings - Maintain structural engineering focus with environment-driven defaults - All tests passing with centralized text management - Improves maintainability and consistency across Teams UI
- Replace ad-hoc test script with comprehensive pytest test suite - Create proper test structure with unit tests for all components - Add tests for TeamsComponents, TeamsResponseAdapter, and TeamsHandler - Use mocks instead of external Azure service dependencies - Add proper async testing with pytest-asyncio - Include comprehensive test documentation and examples - Move old integration tests to scripts/ directory - All 54 tests passing with no external dependencies - Fast, reliable, and CI-ready test suite Key improvements: - No more dependency on Azure services for testing - Proper test isolation with mocks - Comprehensive coverage of all functionality - Fast execution (1-2 seconds for full suite) - Proper async testing patterns - Clear test organization and documentation
…-integration-909b feat: Implement Teams specific handlers and adapters
- Enhanced AuthService with Microsoft Graph integration - Added comprehensive user claims with Graph data - Implemented permission-based access control - Added token validation and caching - Enhanced agent app with permission checking - Added comprehensive test suite for auth service - All 74 tests passing with proper mocking Features: - Microsoft Graph user information retrieval - Group and role-based permissions - Token caching and validation - Enhanced error handling - Permission mapping for different access levels - Integration with existing RAG backend
…-integration-909b Phase 3: Enhanced Microsoft 365 Authentication and Authorization
Check Broken PathsWe have automatically detected the following broken relative paths in your files. Check the file paths and associated broken paths inside them.
|
Check Broken PathsWe have automatically detected the following broken relative paths in your files. Check the file paths and associated broken paths inside them.
|
Collaborator
|
This looks like an accidental PR, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teams & Copilot Agent Refresh :
Web Search Integration :
RAG Enhancements :
Citations & Provenance :
Security & Observability
Infrastructure & Tests: