-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Increase embedding TPM capacity and add note in cloud ingestion guide #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
12e4eca
21cb2a1
cce7b76
2f89549
c0f5e5f
887350f
a0ad452
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,9 +14,11 @@ jobs: | |
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v5 | ||
| - name: Run markdownlint | ||
| uses: articulate/actions-markdownlint@v1 | ||
| - name: Run markdownlint-cli2 | ||
| uses: DavidAnson/markdownlint-cli2-action@v21 | ||
| with: | ||
| config: .github/workflows/markdownlint-config.json | ||
| files: '**/*.md' | ||
| ignore: data/ | ||
| config: .markdownlint-cli2.jsonc | ||
| globs: | | ||
| **/*.md | ||
| !data/** | ||
| !.github/** | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ;)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default markdown files like SECURITY.md are riddled with issues, and we seemed to ignore them before, so I ignored them again here. Could fix em up in future. |
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "config": { | ||
| "default": true, | ||
| "line-length": false, | ||
| "table-column-style": false, | ||
| "MD033": { "allowed_elements": ["br", "details", "summary"] } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We suddenly started getting markdownlint errors, and in debugging, I realized that our markdownlint action was deprecated in favor of this one. David Anson also authors the VS Code extension that we recommend in the repo configuration, so this makes CI consistent with VS Code errors, in theory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good