-
Notifications
You must be signed in to change notification settings - Fork 310
add new sdk samples #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new sdk samples #148
Conversation
change comment dashes to underscores. Docs platform having trouble with the current ids.
add extra space to top
…zureai-samples into dantaylo/nov2024
…zureai-samples into dantaylo/nov2024
|
@kdestin I've added unit tests and fixed a bunch of linter errors -- I suppressed errors around module imports because these files are structured for docs, and lack of type hints because I'm not sure if we want type hints in our docs to keep them simple (but I can easily add those if needed) Please take a look and approve if it looks good to you so these can merge into main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we install this from the public release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we install this from the public release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a README.md for this sample?
| - [chat_with_products.py](): implements chat that grounds response in retrieved documents | ||
| - Uses [assets/grounded_chat.prompty]() for formatting retrieved documents into the chat prompt | ||
| - Implements the [Microsoft AI Chat protocol](https://github.com/microsoft/ai-chat-protocol) for compatibility with evaluation and front-ends | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request was closed

Description
Checklist