Skip to content

Conversation

@qubitron
Copy link
Collaborator

@qubitron qubitron commented Nov 11, 2024

Description

Checklist

  • I have read the contribution guidelines
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@qubitron qubitron requested a review from a team as a code owner November 11, 2024 04:18
@qubitron qubitron requested a review from kdestin November 17, 2024 04:25
@qubitron
Copy link
Collaborator Author

qubitron commented Nov 17, 2024

@kdestin I've added unit tests and fixed a bunch of linter errors -- I suppressed errors around module imports because these files are structured for docs, and lack of type hints because I'm not sure if we want type hints in our docs to keep them simple (but I can easily add those if needed)

Please take a look and approve if it looks good to you so these can merge into main

@qubitron qubitron enabled auto-merge (squash) November 17, 2024 04:27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we install this from the public release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we install this from the public release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a README.md for this sample?

- [chat_with_products.py](): implements chat that grounds response in retrieved documents
- Uses [assets/grounded_chat.prompty]() for formatting retrieved documents into the chat prompt
- Implements the [Microsoft AI Chat protocol](https://github.com/microsoft/ai-chat-protocol) for compatibility with evaluation and front-ends

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth adding in a link to relevant documentation near the start of this sample, similar to what's in the jupyter template.

image

@qubitron qubitron closed this Nov 18, 2024
auto-merge was automatically disabled November 18, 2024 20:14

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants