Skip to content

Conversation

@diondrapeck
Copy link
Contributor

Description

This PR updates the secret detection pre-commit hook script to ignore environment variable patterns for azure secrets if the variable is set to an empty strings. This allows sample creators to include placeholders for secrets in their samples.

I've also updated the contributing guide to recommend the empty string syntax for these placeholders.

Checklist

  • I have read the contribution guidelines
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@diondrapeck diondrapeck requested a review from a team as a code owner December 23, 2024 22:38
@diondrapeck diondrapeck changed the title Add pre commit note Update secrets check to allow empty placehodlers Dec 23, 2024
@diondrapeck diondrapeck merged commit f80d09d into Azure-Samples:main Dec 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants