Skip to content

Added test passed modules from private repository.#183

Closed
Vasanthik07 wants to merge 2 commits intoAzure-Samples:mainfrom
Vasanthik07:forkvasanthi_samples_azure
Closed

Added test passed modules from private repository.#183
Vasanthik07 wants to merge 2 commits intoAzure-Samples:mainfrom
Vasanthik07:forkvasanthi_samples_azure

Conversation

@Vasanthik07
Copy link
Contributor

@Vasanthik07 Vasanthik07 commented Jan 22, 2025

Added test passed modules from private Repo to this repository in Scenarios folder as "samples".

Description

Checklist

  • I have read the contribution guidelines
  • I have coordinated with the docs team (mldocs@microsoft.com) if this PR deletes files or changes any file names or file extensions.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

Added test passed modules in Scenarios folder as samples
@Vasanthik07 Vasanthik07 requested a review from a team as a code owner January 22, 2025 09:29
@Vasanthik07 Vasanthik07 had a problem deploying to external-contribution January 22, 2025 10:09 — with GitHub Actions Failure
@mhurst-microsoft
Copy link

The links in the documentation point back to the original git hub, not to the public repository. That being said, I think we should hold off on moving over any documentation that is not in the specific folder for the samples; and for those documents, we need to check that any links in them are also to resources within the folder, and that the links are changed.

@mhurst-microsoft
Copy link

Looking more closely, I think I will modify my view of the documentation so that we should also include the code and resources under /samples (as well as for the specific examples, e.g., /samples/bing-search), but that all links need to be checked and converted (using relative links) as appropriate. If there are links to documents, code, resources outside of the samples, let's discuss.

@mhurst-microsoft
Copy link

also - I see 2 commits that look similar (identical?); why is that?

@Vasanthik07
Copy link
Contributor Author

Closing this PR. Because it not valid and not more required for further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants