Skip to content

Conversation

@Harmanpreet-Microsoft
Copy link
Contributor

Purpose

This pull request includes several updates to the CI workflow and a test file. The changes focus on improving the robustness of deployment scripts, clarifying environment variable naming, enhancing log extraction logic, and increasing wait times to ensure successful propagation. Additionally, there is an adjustment to a test timeout to improve reliability.

CI Workflow Improvements:

  • Improved region selection logic: The deployment script now sets AZURE_LOCATION to a default (eastus) if VALID_REGION is not set, making deployments more robust.
  • Enhanced deployment log parsing: The extraction of URLs from deployment logs now sorts and deduplicates results, and limits the number of URLs for admin and web services to the first found, increasing accuracy.
  • Standardized environment variable naming: Changed WEB_WEBSITE_URL to FRONTEND_WEBSITE_URL throughout the workflow for clarity and consistency, including updates to output and display steps. [1] [2]

Notification and Scheduling Updates:

  • Added email subjects to notification bodies for failed quota checks and deployment failures, making automated emails more informative. [1] [2]
  • Minor update to cron comment for schedule trigger (removed "PM GMT" for clarity).

Testing and Reliability Enhancements:

  • Increased wait time after deployment from 5 to 25 minutes to ensure propagation before proceeding, reducing flakiness.
  • In the E2E test, increased the timeout after clicking the delete data tab from 5 to 20 seconds to improve reliability when checking for uploaded files.

File/Output Handling Adjustments:

  • Changed the Makefile output check to look for frontend_url.txt instead of web_url.txt for consistency with naming conventions.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft added this pull request to the merge queue Nov 3, 2025
Merged via the queue into Azure-Samples:main with commit 2607457 Nov 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants