Skip to content

Move Entra configs to separate file #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharifrahaman merged 1 commit into from
Aug 19, 2025
Merged

Move Entra configs to separate file #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Project/oAuthConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,10 @@ const authScopes = {
m365Login: []
};

module.exports = {authConfig, authScopes }
const entraCredentialConfig = {
tenantId: 'ENTER_TENANT_ID',
clientId: 'ENTER_CLIENT_ID',
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com/'
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment example URL ends with a trailing slash while the placeholder value 'ACS_RESOURCE_ENDPOINT' doesn't. For consistency, either add a trailing slash to the placeholder or remove it from the example URL.

Suggested change
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com/'
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com'

Copilot uses AI. Check for mistakes.
};

module.exports = {authConfig, authScopes, entraCredentialConfig }
8 changes: 4 additions & 4 deletions Project/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const axios = require("axios");
const bodyParser = require('body-parser');
const msal = require('@azure/msal-node');

const {authConfig, authScopes} = require('./oAuthConfig');
const {authConfig, authScopes, entraCredentialConfig} = require('./oAuthConfig');
const clientId = authConfig.auth.clientId;


Expand Down Expand Up @@ -217,9 +217,9 @@ module.exports = {
try {
res.setHeader('Content-Type', 'application/json');
res.status(200).json({
tenantId: 'ENTER_TENANT_ID',
clientId: 'ENTER_CLIENT_ID',
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com'
tenantId: entraCredentialConfig.tenantId,
clientId: entraCredentialConfig.clientId,
resourceEndpoint: entraCredentialConfig.resourceEndpoint
});
} catch (e) {
console.error(e);
Expand Down
Loading