Skip to content

#4240940: Adding ovc change reason #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vriosrada-msft merged 1 commit into from
Oct 1, 2025
Merged

#4240940: Adding ovc change reason #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project/src/MakeCall/CallCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ export default class CallCard extends React.Component {
const ovcFeature = this.call.feature(Features.OptimalVideoCount);
const ovcChangedHandler = () => {
if (this.state.ovc !== ovcFeature.optimalVideoCount) {
this.setState({ ovc: ovcFeature.optimalVideoCount });
this.setState({ ovc: ovcFeature.optimalVideoCount, lastOvcChangeReason: ovcFeature.lastOvcChangeReason });
this.updateListOfParticipantsToRender('optimalVideoCountChanged');
}
}
Expand Down
11 changes: 10 additions & 1 deletion Project/src/MakeCall/CurrentCallInformation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { AzureLogger } from '@azure/logger';
const CurrentCallInformation = ({ sentResolution, call }) => {
const [ovcFeature, setOvcFeature] = useState();
const [optimalVideoCount, setOptimalVideoCount] = useState(1);
const [lastOvcChangeReason, setLastOvcChangeReason] = useState('Unknown');

useEffect(() => {
try {
Expand All @@ -24,6 +25,9 @@ const CurrentCallInformation = ({ sentResolution, call }) => {

const optimalVideoCountChanged = () => {
setOptimalVideoCount(ovcFeature.optimalVideoCount);
if (ovcFeature.lastOvcChangeReason) {
setLastOvcChangeReason(ovcFeature.lastOvcChangeReason);
}
};

return (
Expand All @@ -34,7 +38,12 @@ const CurrentCallInformation = ({ sentResolution, call }) => {
sentResolution && <div>Sent Resolution: {sentResolution}</div>
}
{
ovcFeature && <div>Optimal Video Count: {optimalVideoCount}</div>
ovcFeature && (
<>
<div>Optimal Video Count: {optimalVideoCount}</div>
<div>Last OVC Change Reason: {lastOvcChangeReason}</div>
</>
)
}
</div>
);
Expand Down
Loading