Skip to content

Remove unused code in workflow #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Remove unused code in workflow #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93be7e1
Rm unused code
pamelafox Oct 21, 2024
1381ee0
Save into other file
pamelafox Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/app-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ jobs:
psql -d postgres -c "ALTER USER ${{ env.POSTGRES_USERNAME }} WITH PASSWORD '${{ env.POSTGRES_PASSWORD }}'"
psql -d postgres -c 'CREATE EXTENSION vector'

# - name: (Windows) Start postgreSQL
# if: matrix.os == 'windows-latest'
# uses: ikalnytskyi/action-setup-postgres@v6
# with:
# username: ${{ env.POSTGRES_USERNAME }}
# password: ${{ env.POSTGRES_PASSWORD }}
# database: ${{ env.POSTGRES_DATABASE }}

- name: Install pgvector
if: matrix.os == 'windows-latest'
shell: cmd
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/evaluate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,15 @@ jobs:
if: ${{ success() }}
run: |
echo "📊 Evaluation Results" >> $GITHUB_STEP_SUMMARY
python -m evaltools summary evals/results --output=markdown >> $GITHUB_STEP_SUMMARY
python -m evaltools summary evals/results --output=markdown >> eval-results.md
cat eval-results.md >> $GITHUB_STEP_SUMMARY

- name: Comment on pull request
uses: actions/github-script@v7
with:
script: |
const fs = require('fs');
const summaryPath = process.env.GITHUB_STEP_SUMMARY;
const summaryPath = "eval-results.md";
const summary = fs.readFileSync(summaryPath, 'utf8');
github.rest.issues.createComment({
issue_number: context.issue.number,
Expand Down