Merged
Conversation
Contributor
alisoliman
commented
Jun 5, 2025
- Fix: AI Analysis for Video on Generation
- Fix: Folder path on Generation
- Fix: AI Analysis Metadata Handling and Viewing
- UX: Add folder to the sidebar when created in the dropdown
- chore: Add filename endpoint to the image generation
- chore: Reduce the pop ups when generating assets
…ove tag generation logic
…resh functionality
…etion and improve toast notifications
There was a problem hiding this comment.
Pull Request Overview
This PR enhances folder support in video workflows, refines user notifications by consolidating toasts, and adds server-side filename normalization for image generation.
- Persist and respect
foldermetadata throughout the video queue and gallery. - Replace multiple individual pop-ups with single loading-to-success/error toasts.
- Introduce filename generation and normalization endpoints for image assets.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/context/video-queue-context.tsx | Store folder in queue items and adjust upload/download logic |
| frontend/context/folder-context.tsx | New context for triggering folder list refresh |
| frontend/components/app-sidebar.tsx | Inject folder context to re-fetch folders when updated |
| backend/api/endpoints/videos.py | Attach folder_path metadata when uploading generated videos |
| backend/api/endpoints/images.py | Add normalize_filename and generate_filename_for_prompt functions |
| backend/core/azure_storage.py | Support provided filenames and conflict resolution in blob uploads |
Comments suppressed due to low confidence (2)
backend/api/endpoints/images.py:73
- The
remodule is used here but not imported at the top of the file, which will cause aNameError. Please addimport re.
stem = re.sub(r'[^a-zA-Z0-9_\-.]', '_', stem)
backend/api/endpoints/videos.py:326
- The front-end expects the metadata key
folderbut here you addfolder_path. Use the same key (folder) or update front-end logic to readfolder_pathto ensure folder metadata is preserved.
upload_metadata["folder_path"] = azure_service.normalize_folder_path(
backend/core/azure_storage.py
Outdated
| # Create blob name with the provided filename | ||
| blob_name = f"{normalized_folder_path}{filename_without_ext}{ext}" | ||
| file_id = filename_without_ext # For backward compatibility in response | ||
| print(f"Azure Storage: Using provided filename: {blob_name}") |
There was a problem hiding this comment.
[nitpick] Replace print statements with the module's logger for consistent logging and better control over log levels.
Suggested change
| print(f"Azure Storage: Using provided filename: {blob_name}") | |
| logger.info(f"Azure Storage: Using provided filename: {blob_name}") |
…ocessing for cleaner code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.