Skip to content

Conversation

@alisoliman
Copy link
Contributor

  • Fix: AI Analysis for Video on Generation
  • Fix: Folder path on Generation
  • Fix: AI Analysis Metadata Handling and Viewing
  • UX: Add folder to the sidebar when created in the dropdown
  • chore: Add filename endpoint to the image generation
  • chore: Reduce the pop ups when generating assets

@alisoliman alisoliman requested review from andreaskopp and Copilot June 5, 2025 13:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances folder support in video workflows, refines user notifications by consolidating toasts, and adds server-side filename normalization for image generation.

  • Persist and respect folder metadata throughout the video queue and gallery.
  • Replace multiple individual pop-ups with single loading-to-success/error toasts.
  • Introduce filename generation and normalization endpoints for image assets.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/context/video-queue-context.tsx Store folder in queue items and adjust upload/download logic
frontend/context/folder-context.tsx New context for triggering folder list refresh
frontend/components/app-sidebar.tsx Inject folder context to re-fetch folders when updated
backend/api/endpoints/videos.py Attach folder_path metadata when uploading generated videos
backend/api/endpoints/images.py Add normalize_filename and generate_filename_for_prompt functions
backend/core/azure_storage.py Support provided filenames and conflict resolution in blob uploads
Comments suppressed due to low confidence (2)

backend/api/endpoints/images.py:73

  • The re module is used here but not imported at the top of the file, which will cause a NameError. Please add import re.
stem = re.sub(r'[^a-zA-Z0-9_\-.]', '_', stem)

backend/api/endpoints/videos.py:326

  • The front-end expects the metadata key folder but here you add folder_path. Use the same key (folder) or update front-end logic to read folder_path to ensure folder metadata is preserved.
upload_metadata["folder_path"] = azure_service.normalize_folder_path(

# Create blob name with the provided filename
blob_name = f"{normalized_folder_path}{filename_without_ext}{ext}"
file_id = filename_without_ext # For backward compatibility in response
print(f"Azure Storage: Using provided filename: {blob_name}")
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Replace print statements with the module's logger for consistent logging and better control over log levels.

Suggested change
print(f"Azure Storage: Using provided filename: {blob_name}")
logger.info(f"Azure Storage: Using provided filename: {blob_name}")

Copilot uses AI. Check for mistakes.
@alisoliman alisoliman merged commit 12b022f into main Jun 5, 2025
3 checks passed
@alisoliman alisoliman deleted the fix-video-experience branch June 5, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants