-
Notifications
You must be signed in to change notification settings - Fork 58
Fix video experience #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alisoliman
commented
Jun 5, 2025
- Fix: AI Analysis for Video on Generation
- Fix: Folder path on Generation
- Fix: AI Analysis Metadata Handling and Viewing
- UX: Add folder to the sidebar when created in the dropdown
- chore: Add filename endpoint to the image generation
- chore: Reduce the pop ups when generating assets
…ove tag generation logic
…resh functionality
…etion and improve toast notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances folder support in video workflows, refines user notifications by consolidating toasts, and adds server-side filename normalization for image generation.
- Persist and respect
foldermetadata throughout the video queue and gallery. - Replace multiple individual pop-ups with single loading-to-success/error toasts.
- Introduce filename generation and normalization endpoints for image assets.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/context/video-queue-context.tsx | Store folder in queue items and adjust upload/download logic |
| frontend/context/folder-context.tsx | New context for triggering folder list refresh |
| frontend/components/app-sidebar.tsx | Inject folder context to re-fetch folders when updated |
| backend/api/endpoints/videos.py | Attach folder_path metadata when uploading generated videos |
| backend/api/endpoints/images.py | Add normalize_filename and generate_filename_for_prompt functions |
| backend/core/azure_storage.py | Support provided filenames and conflict resolution in blob uploads |
Comments suppressed due to low confidence (2)
backend/api/endpoints/images.py:73
- The
remodule is used here but not imported at the top of the file, which will cause aNameError. Please addimport re.
stem = re.sub(r'[^a-zA-Z0-9_\-.]', '_', stem)
backend/api/endpoints/videos.py:326
- The front-end expects the metadata key
folderbut here you addfolder_path. Use the same key (folder) or update front-end logic to readfolder_pathto ensure folder metadata is preserved.
upload_metadata["folder_path"] = azure_service.normalize_folder_path(
backend/core/azure_storage.py
Outdated
| # Create blob name with the provided filename | ||
| blob_name = f"{normalized_folder_path}{filename_without_ext}{ext}" | ||
| file_id = filename_without_ext # For backward compatibility in response | ||
| print(f"Azure Storage: Using provided filename: {blob_name}") |
Copilot
AI
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Replace print statements with the module's logger for consistent logging and better control over log levels.
| print(f"Azure Storage: Using provided filename: {blob_name}") | |
| logger.info(f"Azure Storage: Using provided filename: {blob_name}") |
…ocessing for cleaner code