fix: ensure needed variables for frontend make run target are set #3707
Conversation
The run target of the frontend's Makefile was not working because some of the variables that it referenced were not being set correctly. This commit updates Frontend's Env.mk to ensure that those end up being resolved and resolved with the expected contents when it is included in the Makefile via the setup-templatize-env.mk in the project root.
mbarnes
left a comment
mbarnes
left a comment
There was a problem hiding this comment.
Thanks for this!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbarnes, miguelsorianod The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
deleted the
msoriano-fix-frontend-make-run-args
branch
|
@miguelsorianod: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The run target of the frontend's Makefile was not working because some of the variables that it referenced were not being set correctly.
This commit updates Frontend's Env.mk to ensure that those end up being resolved and resolved with the expected contents when it is included in the Makefile via the setup-templatize-env.mk in the project root.