Skip to content

Comments

Add logging of body content when possible#4145

Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom
show-written-bytes
Feb 21, 2026
Merged

Add logging of body content when possible#4145
openshift-merge-bot[bot] merged 1 commit intomainfrom
show-written-bytes

Conversation

@deads2k
Copy link
Collaborator

@deads2k deads2k commented Feb 18, 2026

We do this because ARM (a proxy of some sort) is claiming the frontend broke the contract on list. Currently, our code thinks we're fulfilling the contract. This will output the actual content so we can make a determination.

We do this because ARM (a proxy of some sort) is claiming the frontend
broke the contract on list. Currently, our code thinks we're fulfilling
the contract.  This will output the actual content so we can make a
determination.
@openshift-ci openshift-ci bot requested review from geoberle and mbarnes February 18, 2026 17:12
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Collaborator Author

deads2k commented Feb 18, 2026

/hold I'd like to see this output useful data in CI prior ot merge.

@deads2k
Copy link
Collaborator Author

deads2k commented Feb 19, 2026

/retest

1 similar comment
@deads2k
Copy link
Collaborator Author

deads2k commented Feb 20, 2026

/retest

@stevekuznetsov
Copy link
Contributor

/hold cancel

Body is printed correctly

@openshift-merge-bot openshift-merge-bot bot merged commit 03a5586 into main Feb 21, 2026
14 of 15 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the show-written-bytes branch February 21, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants