Skip to content

Comments

Implement OTEL audit logging in Admin API#4160

Merged
openshift-merge-bot[bot] merged 2 commits intomainfrom
admin-api-audit-log
Feb 20, 2026
Merged

Implement OTEL audit logging in Admin API#4160
openshift-merge-bot[bot] merged 2 commits intomainfrom
admin-api-audit-log

Conversation

@geoberle
Copy link
Collaborator

  • Add audit logging middleware to Admin API, capturing WHO/WHAT/WHEN for every request via go-otel-audit
  • Refactor shared CreateOtelAuditMsg to accept caller-specific operation description, access level, and identities (previously hardcoded to Frontend values)
  • Share response writer to capture status codes with frontend
  • Add audit.connectSocket config for mdsd socket connection

ARO-24628

What

Why

Special notes for your reviewer

@openshift-ci openshift-ci bot requested review from deads2k and janboll February 19, 2026 18:45
@geoberle geoberle force-pushed the admin-api-audit-log branch 2 times, most recently from f38c154 to 565ff71 Compare February 20, 2026 08:12
@janboll
Copy link
Collaborator

janboll commented Feb 20, 2026

/lgtm

@janboll
Copy link
Collaborator

janboll commented Feb 20, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2026
- Add audit logging middleware to Admin API, capturing WHO/WHAT/WHEN for every request via `go-otel-audit`
- Refactor shared `CreateOtelAuditMsg` to accept caller-specific operation description, access level, and identities (previously hardcoded to Frontend values)
- Share response writer to capture status codes with frontend
- Add `audit.connectSocket` config for mdsd socket connection

[ARO-24628](https://issues.redhat.com/browse/ARO-24628)

Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
@geoberle geoberle force-pushed the admin-api-audit-log branch from 9d2d858 to 26bc38c Compare February 20, 2026 14:11
@openshift-ci openshift-ci bot removed the lgtm label Feb 20, 2026
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2026
@geoberle geoberle force-pushed the admin-api-audit-log branch from 4fe609e to f397acd Compare February 20, 2026 19:32
@openshift-ci openshift-ci bot removed the lgtm label Feb 20, 2026
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geoberle, janboll, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [geoberle,janboll,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geoberle
Copy link
Collaborator Author

/test integration

@openshift-merge-bot openshift-merge-bot bot merged commit ea99b4d into main Feb 20, 2026
15 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the admin-api-audit-log branch February 20, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants