frontend changes for defender#4164
Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Collaborator
Author
|
/test e2e-parallel |
Collaborator
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geoberle, sclarkso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
/test e2e-parallel |
1 similar comment
Collaborator
|
/test e2e-parallel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change frontend audit volume mount to its parent directory
Why
Defender for cloud was enabled by policy in INT. If a defender pod crashes the inode of the asa folder changes and otel cannot reconnect. If you mount the parent directory, the asa folder can be deleted and recreated if the defender pod crashes and otel can reconnect, preventing the frontend from silently failing.
https://docs.google.com/document/d/1ufDbsSOZgOiqRkwNim5C6Nnosw2Q1QQqrt6jjY8vazI/edit?tab=t.0#heading=h.3p4jw99p07sh
Special notes for your reviewer
This has been manually tested in INT (with defender managing /var/run/mdsd/asa) and in Stage (ama-metrics manages /var/run/mdsd/asa). Relevant otel code: https://github.com/microsoft/go-otel-audit/blob/c657aa56f8283563dc98e5ce8507a62554215aa9/audit/conn/domainsocket.go#L33. The asa folder exists either way so that is what it uses, it just doesn't break if the folder is recreated.