Skip to content

follow up: minor updates to the "golden path" negative test case#4776

Merged
1 commit merged intomainfrom
mvacula/followup-simple-negative-cases
Apr 9, 2026
Merged

follow up: minor updates to the "golden path" negative test case#4776
1 commit merged intomainfrom
mvacula/followup-simple-negative-cases

Conversation

@mvacula02
Copy link
Copy Markdown
Collaborator

What

  • refactor logging in CheckExpectedError()
  • refactor invalid node pool update test case to not cause a spec wide failure on node pool GET failure

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvacula02
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-bot openshift-merge-bot bot closed this pull request by merging all changes into main in bec4074 Apr 9, 2026
@openshift-merge-bot openshift-merge-bot bot deleted the mvacula/followup-simple-negative-cases branch April 9, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant