Skip to content

Fix Makefile bare export leaking all variables to subprocesses #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuxerrante wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Fix Makefile bare export leaking all variables to subprocesses #4653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
SHELL = /bin/bash

# Source local env file if present (gitignored)
-include .env
export
# PYTHONPATH default for Python targets; overridden if 'source env' was run.
PYTHONPATH ?= python/az/aro
export PYTHONPATH

TAG ?= $(shell git describe --exact-match 2>/dev/null)
COMMIT = $(shell git rev-parse --short=7 HEAD)$(shell [[ $$(git status --porcelain) = "" ]] || echo -dirty)
Expand Down
1 change: 1 addition & 0 deletions env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export AZURE_PREFIX="${AZURE_PREFIX:-$USER}"
export LOCATION="${LOCATION:-westeurope}"
export NO_CACHE=false
export AZURE_EXTENSION_DEV_SOURCES="$(pwd)/python"
export PYTHONPATH=python/az/aro

export CLUSTER_RESOURCEGROUP="${AZURE_PREFIX}-v4-$LOCATION"
export CLUSTER_NAME="${AZURE_PREFIX}-aro-cluster"
Expand Down
Loading