Skip to content

make a webhook to remind us to run the needful make commands #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hlipsig wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −3
Open

make a webhook to remind us to run the needful make commands #4659

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2007547
make a webhook to remind us to run the needful make commands
hlipsig Mar 5, 2026
93cb6e6
pre-push instead of commit
hlipsig Mar 5, 2026
c6b3e5a
Update hack/git/hooks/pre-push
hlipsig Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions hack/git/hooks/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,13 @@ Replace <NEW-BRANCH-NAME> with a valid branch name and try again."
exit 1
fi

echo "Before committing, ensure you've run the required make commands:"
echo " - make generate"
echo " - make imports"
read -r -p "Have you run all required make commands? [y/N] " run_make_commands
if [[ ! "${run_make_commands}" =~ ^([yY][eE][sS]|[yY])$ ]]; then
echo "Commit aborted. Run the required make commands and try again."
exit 1
fi

exit 0
Loading