Open
Conversation
Add optional information on how to install Go via gvm Add variable to reference golint version to be installed * This prevents us from hardcoding a version in the setup doc. Add makefile.md documentation * Seperating this simplifies our primary dev-env-setup document. Add bash environment helpers documentation Update dev-setup docs relocating Debian and Mac OS dependencies * They should be grouped under all OS specific dependencies to be installed. Fix formatting issues
…local rp development The primary setup document was getting very cluttered. This helps it to be more easily read and understood.
Simplifies running yq in a container.
It seems that -y is no longer accepted by yq.
Cleaned up scripts by moving some functions into hack/util.sh
Fixed sourcing path
Remove unnecessary variable name references
* A name ref for the image variable caused an interesting problem when running yq as a container. yq image assignment was attempting to overwrite hive_image. Passing the variable as a value mitigated this.
s-fairchild
requested review from
alcasim,
cadenmarchese,
hlipsig,
jharrington22,
kimorris27,
mociarain,
mrWinston,
sankur-codes,
tiguelu,
tsatam,
tuxerrante,
ventifus,
wanghaoran1988 and
yjst2012
as code owners
Closed
s-fairchild
force-pushed
the
s-fairchild/ARO-25143
branch
from
1e094d3 to
3342ea3
Compare
s-fairchild
force-pushed
the
s-fairchild/ARO-25143
branch
2 times, most recently
from
302720b to
6263ea9
Compare
* Add additional bash script logging utilities
* Update default hive hash to latest
* Update hive-dev-install.sh
* Simplify
* Create hive secret completely in memory to remove writing of
temporary pull secret to filesystem
* Check if util.sh has been already been sourced before attempting to source it.
* Prevents failures caused by re-assigning readonly variables.
Correct Hive repository url
Update default hive image tag to use full commits (as used in the new
repo)
s-fairchild
force-pushed
the
s-fairchild/ARO-25143
branch
from
6263ea9 to
b613acb
Compare
Bash uses spaces for indentation. Tabs were erroneously added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes
https://issues.redhat.com/browse/ARO-25143
https://issues.redhat.com/browse/ARO-25110
Related to https://issues.redhat.com/browse/ARO-24815#
The fixes to
hive-generate-config.shtechnically block me from deploying a full service dev rp. Although it's easily fixed by using this branch locally before merging.What this PR does / why we need it:
yqappears to have remove the-yoption in it's latest release.hack/util.shhack/util.shLOG_LEVEL(defaults to info)LOG_LEVELwill be loggedDEBUGtoXTRACEto avoid confusingLOG_LEVEL_DEBUGwithset -xtraceTest plan for issue:
Manually tested passing and failing conditions in my local dev environment.
Here are some examples of how the logging utility updates can be used:
Is there any documentation that needs to be updated for this PR?
There should be a document added to
docs/dev-environmentdetailing how to usehack/util.shlog functions. I'd prefer to do this in a follow up PR.How do you know this will function as expected in production?
N/A dev environments only