Merged
Conversation
Devinwong
requested review from
AbelHu,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Devinwong
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes several bugs related to scriptless node provisioning:
Changes:
- Changed the LoadBalancerStandard constant value from "Standard" to "standard" for consistency with other constants
- Fixed double base64 encoding issue with service principal secrets by removing the extra encoding layer in aks-node-controller
- Updated e2e secret leak validation to use exact word matching instead of partial matching to reduce false positives
- Added test coverage for kubelet flag validation and service principal configuration
- Enhanced e2e log collection to include additional configuration files for debugging
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| aks-node-controller/helpers/const.go | Changed LoadBalancerStandard constant from "Standard" to "standard" for consistency |
| aks-node-controller/helpers/utils_test.go | Updated test expectations to match new lowercase constant values and added comprehensive tests for kubelet flag validation |
| aks-node-controller/parser/helper.go | Removed getServicePrincipalFileContent helper function that was adding extra base64 encoding |
| aks-node-controller/parser/parser.go | Updated to directly use ServicePrincipalSecret without additional encoding |
| aks-node-controller/parser/parser_test.go | Added test to verify service principal secret is passed without double encoding |
| e2e/node_config.go | Updated test templates to use base64 encoded service principal secrets |
| e2e/validators.go | Added fileHasExactContent function and ValidateFileExcludesExactContent for exact word matching, updated ValidateLeakedSecrets to use exact matching |
| e2e/vmss.go | Added extraction of aks-node-controller configuration files and azure.json for debugging |
e2e/validators.go
Outdated
| } | ||
|
|
||
| // ValidateFileHasContent passes the test if the specified file contains the specified contents. | ||
| // The contents doesn't need to surrounded by non-word characters. |
There was a problem hiding this comment.
Typo in the comment: "doesn't need to surrounded" should be "doesn't need to be surrounded".
e2e/validators.go
Outdated
| } | ||
|
|
||
| // ValidateFileExcludesContent fails the test if the specified file contains the specified contents. | ||
| // The contents doesn't need to surrounded by non-word characters. |
There was a problem hiding this comment.
Typo in the comment: "doesn't need to surrounded" should be "doesn't need to be surrounded".
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…gentBaker into devinwon/scriptless_bugs
Contributor
|
@Devinwong I've opened a new pull request, #7699, to work on those changes. Once the pull request is ready, I'll request review from you. |
Collaborator
Author
|
Windows e2e failed. But the changes here is Linux Scriptless only. |
cameronmeissner
approved these changes
Jan 23, 2026
awesomenix
approved these changes
Jan 23, 2026
Devinwong
added a commit
that referenced
this pull request
Feb 3, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Devin Wong <wongsiosun@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixing a few bugs we found recently:
ValidateLeakedSecretsto check the whole word instead of partial word match.Which issue(s) this PR fixes:
Fixes #