Open
Conversation
github-actions
bot
added
the
components
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-introduces Windows Server 2019 (containerd) support across the Windows VHD build pipeline, settings/schemas, component manifests, and E2E validation to ensure WS2019 images can be built and tested again.
Changes:
- Re-add WS2019 (
2019-containerd) base version + registry key settings and extend schemas to allowws2019package overrides. - Add WS2019-specific component entries (container images + containerd package variants) and corresponding unit/E2E tests.
- Wire WS2019 back into Windows VHD build/test pipelines and GitHub signature validation workflow.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
vhdbuilder/packer/windows/windows_settings.json |
Adds WS2019 base version and WS2019-specific registry keys. |
vhdbuilder/packer/windows/components_json_helpers.tests.ps1 |
Adds Pester coverage for WS2019 container images and containerd package selection. |
vhdbuilder/packer/windows/components-test.json |
Adds ws2019 downloadURIs for containerd package in the test fixture. |
schemas/windows_settings.cue |
Extends allowed Windows base versions to include 2019-containerd. |
schemas/components.cue |
Extends Windows distro keys to allow ws2019 overrides. |
parts/common/components.json |
Adds WS2019 container image tags and ws2019 containerd package overrides. |
e2e/scenario_win_test.go |
Adds WS2019 scenario coverage + caching regression scenario. |
e2e/config/vhd.go |
Adds WS2019 containerd VHD image definition to E2E config. |
e2e/components/components_test.go |
Adds tests asserting WS2019 image tags and kubelet version availability for 1.32. |
.pipelines/templates/.build-and-test-windows-vhds-template.yaml |
Adds a WS2019 build stage option (gen1). |
.pipelines/.vsts-vhd-builder-release-windows.yaml |
Adds release pipeline parameter to build WS2019 containerd. |
.pipelines/.vsts-vhd-builder-pr-windows.yaml |
Enables WS2019 containerd builds in PR validation runs. |
.pipelines/.vsts-Marketpalce-win.yaml |
Minor cleanup related to marketplace pipeline entry. |
.github/workflows/validate-windows-binary-signature.yaml |
Adds a WS2019 variant of the signature validation job. |
This reverts commit 8dbbf47.
janenotjung-hue
force-pushed
the
janejung/putting-ws2019-back
branch
from
15b6a43 to
d965f88
Compare
janenotjung-hue
requested review from
AbelHu,
Devinwong,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #