Skip to content

Conversation

@prtanej
Copy link
Contributor

@prtanej prtanej commented Jun 18, 2024

Required items, please complete

Change(s):

  • Updated the CEFOverview workbook to include workspace parameter & removed default values

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@prtanej prtanej requested review from a team as code owners June 18, 2024 13:32
@v-atulyadav v-atulyadav added the Workbook Workbook specialty review needed label Jun 19, 2024
@v-shukore v-shukore requested a review from a team as a code owner July 9, 2024 08:51
@v-shukore v-shukore marked this pull request as draft August 30, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content-Package Workbook Workbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants