Skip to content

Fortinet FortiGate WebSession Parsers Parsing Fix & Additions#10865

Closed
t-pol wants to merge 49 commits intoAzure:masterfrom
t-pol:ASimWebSessionFortinetFortiGate_change
Closed

Fortinet FortiGate WebSession Parsers Parsing Fix & Additions#10865
t-pol wants to merge 49 commits intoAzure:masterfrom
t-pol:ASimWebSessionFortinetFortiGate_change

Conversation

@t-pol
Copy link

@t-pol t-pol commented Jul 24, 2024

Required items, please complete

Change(s):

  • Update kql ASimWebSessionFortinetFortiGate.yaml
  • Update kql vimWebSessionFortinetFortiGate.yaml

Reason for Change(s):

  • When there is no User Agent string in AdditionalExtensions, the parsing of HttpRequestMethod fails.
    Incorrect parsing of HttpRequestMethod and HttpUserAgent.
    300977692-5147bab0-35b3-4861-9610-7e0ece0a3628

  • Adding NetworkApplicationProtocol field in the project-rename. (Optional field in the parser, but it exists in FortiGate logs)

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • No

@t-pol t-pol requested review from a team as code owners July 24, 2024 08:34
@t-pol
Copy link
Author

t-pol commented Jul 24, 2024

@microsoft-github-policy-service agree

@v-atulyadav
Copy link
Collaborator

Hi @t-pol,
PR is having validation failures please check. Thanks

@v-atulyadav
Copy link
Collaborator

Hi @t-pol,
Please investigate the failed validations. Thanks

@t-pol
Copy link
Author

t-pol commented Aug 2, 2024

The issues have been fixed. Thanks

@v-atulyadav
Copy link
Collaborator

Thanks @t-pol.

@t-pol
Copy link
Author

t-pol commented Aug 13, 2024

Hello, is there any feedback regarding the parser ?

@Alekhya0824
Copy link
Contributor

can you please add tester files after testing
this is the documentation to add schema tester and data tester https://learn.microsoft.com/en-us/azure/sentinel/normalization-develop-parsers#test-parsers
These schema tester and data tester files can add under Tests files

@v-atulyadav
Copy link
Collaborator

Hi @t-pol, please check above comments from @Alekhya0824 and act accordingly. Thanks

@v-atulyadav
Copy link
Collaborator

Hi @t-pol,
Please respond on above asks. Thanks

@t-pol
Copy link
Author

t-pol commented Dec 10, 2024

Hello,
Apologies for the late response.
The only pending error is in the input parameter "eventresultdetails_in".
Based on the documentation https://learn.microsoft.com/en-us/azure/sentinel/normalization-schema-web
EventResultDetails field, which typically reports the HTTP Status Code.
However, Fortigate does not populate http status code so far. Due to this EventResultDetails has alreardy been set as N/A to the existing parsers. Unfortunately, i can not fix this issue.
Thanks.

@vakohl
Copy link
Contributor

vakohl commented Dec 10, 2024

@t-pol Thankyou for your updates. Can we try below?

  1. Remove this mapping from both ASIM and VIM=> | extend EventResultDetails = "NA"
  2. Remove this mapping from both ASIM and VIM=> HttpStatusCode = EventResultDetails
  3. In the vim file use filter => | where (array_length(eventresultdetails_in) == 0
  4. Remove filter=> | where (array_length(eventresultdetails_in) == 0 or tostring(EventResultDetails) has_any(eventresultdetails_in))

@t-pol t-pol requested a review from vakohl December 11, 2024 12:58
@t-pol
Copy link
Author

t-pol commented Dec 11, 2024

Changes have been applied.
Thanks

@v-atulyadav
Copy link
Collaborator

Hi @t-pol,
The validations associated with this pull request are not progressing. Please ensure you have the latest updates from the master branch. Thanks

@v-atulyadav
Copy link
Collaborator

Hi @t-pol,
Thank you for your reply. Please review one of the validations that did not pass. Thanks

@t-pol
Copy link
Author

t-pol commented Jan 17, 2025

Hello @v-atulyadav , I have fixed the pending issues. Please proceed and check the pr.
Thanks

@t-pol
Copy link
Author

t-pol commented Jan 29, 2025

Hello @v-atulyadav @vakohl , I have fixed the pending issues. Please proceed and check the pr.
Thanks

@v-atulyadav
Copy link
Collaborator

Hi @t-pol,
Please address one of the checks that did not pass. Thanks

@t-pol
Copy link
Author

t-pol commented Mar 20, 2025

It is not an error to the parser or the changes that i have performed.

 Error: AADSTS7002138: No matching federated identity record found for presented assertion subject 'repo:Azure/Azure-Sentinel:pull_request'. 

Please check the relevant error.
Thanks

@vakohl
Copy link
Contributor

vakohl commented Jun 16, 2025

Closing this PR, as same changes are being done using different PR.
#12312

@vakohl vakohl closed this Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants