Fixing Dragos arm-ttk id from resourceId validation errors#11726
Merged
rahul0216 merged 6 commits intoAzure:masterfrom Feb 3, 2025
Merged
Fixing Dragos arm-ttk id from resourceId validation errors#11726rahul0216 merged 6 commits intoAzure:masterfrom
rahul0216 merged 6 commits intoAzure:masterfrom
Conversation
Contributor
Author
|
Any updates @v-prasadboke ? |
Contributor
Author
|
The detections validation PR check is failing but I don't see how it relates to any of the changes that I made. Looking at other runs of this check, it seems to have issues when the PR comes from a branch that is not part of the main Azure/Azure-Sentinel repo as show below:
Can you please advise? |
Contributor
|
Hello @dragosinc-sentinel, failure for id is an exception. We can ignore it. I have packaged the solution now |
v-prasadboke
approved these changes
Feb 3, 2025
Contributor
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Tools/Create-Azure-Sentinel-Solution/V3/createSolutionV3.ps1script, which apparently has a bug as it produces ARM templates that do not validate. Therefore as part of this PR we followed the guidance listed here: https://github.com/Azure/Azure-Sentinel/tree/e92286da7d185c99c6d30c2cb8c86bbeca1a99ba/Tools/Create-Azure-Sentinel-Solution/V3#ids-should-be-derived-from-resourceids and manually fixed the id offendingidproperties.Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: