Fix the instructions step in template_WindowsFirewallAma.JSON#12412
Merged
v-atulyadav merged 4 commits intoAzure:masterfrom Jun 26, 2025
Merged
Fix the instructions step in template_WindowsFirewallAma.JSON#12412v-atulyadav merged 4 commits intoAzure:masterfrom
v-atulyadav merged 4 commits intoAzure:masterfrom
Conversation
Fix the instructions step to use thr right one. 4 - CiscoASA AMA instruction step 5 - Windows Firewall AMA instruction step
haim-na
previously approved these changes
Jun 25, 2025
Contributor
|
@v-atulyadav please review |
This reverts commit 525a063.
v-atulyadav
approved these changes
Jun 26, 2025
v-sabiraj
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the instructions step to use thr right one.
4 - CiscoASA AMA instruction step
5 - Windows Firewall AMA instruction step
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.