Rename solution and small fixes#12634
Merged
v-atulyadav merged 8 commits intoAzure:masterfrom Aug 14, 2025
Merged
Conversation
v-atulyadav
added
Solution
| "title": "2. Maintain the data collection endpoint details and authentication info in Onapsis Integration", | ||
| "description": "Share the data collection endpoint URL and authentication info with the Onapsis Integration administrator to configure the Onapsis Integration to send data to the data collection endpoint.\n\nLearn more from [this blog series](https://community.Onapsis.com/t5/enterprise-resource-planning-blog-posts-by-members/ultimate-blog-series-Onapsis-logserv-integration-with-microsoft-sentinel/ba-p/14126401).", | ||
| "title": "2. Maintain the data collection endpoint details and authentication info in Onapsis Defend Integration", | ||
| "description": "Share the data collection endpoint URL and authentication info with the Onapsis Defend Integration administrator to configure the Onapsis Defend Integration to send data to the data collection endpoint.\n\nLearn more from [this blog series](https://community.Onapsis.com/t5/enterprise-resource-planning-blog-posts-by-members/ultimate-blog-series-Onapsis-logserv-integration-with-microsoft-sentinel/ba-p/14126401).", |
Contributor
There was a problem hiding this comment.
the blog ref points still at the sap logserv solution. It should be a public onapsis doc rgearding setup or similar
| "Data Connectors/Onapsis_PUSH_CCP/Onapsis_connectorDefinition.json" | ||
| ], | ||
| "BasePath": "C:\\GitHub\\Azure-Sentinel\\Solutions\\Onapsis Integration", | ||
| "BasePath": "C:\\GitHub\\Azure-Sentinel\\Solutions\\Onapsis Defend: Integrate Unmatched SAP Threat Detection & Intel with Microsoft Sentinel", |
Contributor
There was a problem hiding this comment.
keep the internal solution path simpler as it is not customer facing. "Onapsis Defend" should be good enough.
MartinPankraz
suggested changes
Aug 11, 2025
Contributor
MartinPankraz
left a comment
MartinPankraz
left a comment
There was a problem hiding this comment.
Please adjust the base path and fix the logserv blog link
| "Data Connectors/Onapsis_PUSH_CCP/Onapsis_connectorDefinition.json" | ||
| ], | ||
| "BasePath": "C:\\GitHub\\Azure-Sentinel\\Solutions\\Onapsis Defend: Integrate Unmatched SAP Threat Detection & Intel with Microsoft Sentinel", | ||
| "BasePath": "C:\\GitHub\\Azure-Sentinel\\Solutions\\Onapsis Defend", |
Contributor
There was a problem hiding this comment.
basepath changed but actual folder on the repos still has the long name with ":Integrate..."
MartinPankraz
suggested changes
Aug 12, 2025
Contributor
MartinPankraz
left a comment
MartinPankraz
left a comment
There was a problem hiding this comment.
Please adjust the repos folder to match the base path and rebuild to make sure structure is picked up correctly.
MartinPankraz
approved these changes
Aug 12, 2025
v-shukore
approved these changes
Aug 14, 2025
MartinPankraz
approved these changes
Aug 14, 2025
Contributor
MartinPankraz
left a comment
MartinPankraz
left a comment
There was a problem hiding this comment.
all tested. Good to go
Contributor
|
Test results: 
Good to go |
v-atulyadav
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: