Skip to content

Fixes to Anvilogic CCF Data Connector#12648

Merged
rahul0216 merged 16 commits intoAzure:masterfrom
oakhan3:master
Sep 1, 2025
Merged

Fixes to Anvilogic CCF Data Connector#12648
rahul0216 merged 16 commits intoAzure:masterfrom
oakhan3:master

Conversation

@jesweene
Copy link
Contributor

@jesweene jesweene commented Aug 13, 2025

Required items, please complete

Change(s):

  • Adds custom log needed for DCR
  • Fixes Analytics Rule template
  • Replaces instances of "AnviLogic" with correct "Anvilogic"
  • Updates Package

Reason for Change(s):

  • The changes made to the initial PR changed the overall way the Data Connector was intended to work, this likely was my fault by not including the Anvilogic_Alerts_CL arm template in the directory and not directly translating the Analytics Rule yaml exactly as intended

Version Updated:

  • No version change as this hasn't been published yet

Testing Completed:

  • Need help

Checked that the validations are passing and have addressed any issues that are present:

  • Need help

@v-maheshbh
Copy link
Contributor

Hi @jesweene Please check mainTemplate Must Not Contain Hardcoded Uri.

@jesweene
Copy link
Contributor Author

@v-maheshbh I believe I should have addressed your comment in the previous commit, not sure what I'm doing wrong that causes testim.io to fail

@v-maheshbh
Copy link
Contributor

Hi @jesweene we can ignore the testim.io validation check. please check other failing check. thanks

@v-maheshbh
Copy link
Contributor

v-maheshbh commented Aug 26, 2025

hi @jesweene It appears that the main template has been modified manually, so we kindly request you to repackage the solution. Additionally, please update the release notes to list the latest version at the top, as per the standard format.
. check this link https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md
Thanks.

@jesweene
Copy link
Contributor Author

hi @jesweene It appears that the main template has been modified manually, so we kindly request you to repackage the solution. Additionally, please update the release notes to list the latest version at the top, as per the standard format. . check this link https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md Thanks.

Thanks @v-maheshbh, I used the packaging tool let me know if there are any other changes needed. We never published 3.0.0 so when using the packaging tool it defaulted to 3.0.0. I believe that is expected, but please let me know if that is incorrect?

v-maheshbh
v-maheshbh previously approved these changes Aug 28, 2025
@v-maheshbh
Copy link
Contributor

Hi @jesweene Please revert the changes to queryFrequency, queryPeriod, and suppressionDuration values — these fields are case-sensitive and should remain lowercase (e.g., 5m, 5h) to ensure proper functionality.

Also, if possible, kindly grant me contributor access to the branch so I can make the necessary updates. I’d also like to rename Anvilogic_Alerts_CL to Anvilogic_Table to align with the standard naming convention.

image

@v-maheshbh v-maheshbh self-requested a review August 28, 2025 06:43
@v-maheshbh v-maheshbh dismissed their stale review August 28, 2025 06:50

added comments.

@jesweene
Copy link
Contributor Author

@v-maheshbh when I test deploying the connector locally I get this error initially:
image
it seems like the way that package tool combines the contents in /Data Connectors/Anvilogic_CCF that there's a race condtion or an order of operation issuer where the DCR is created before the table? I was able to previously solve this by creating the table at install of the CCF solution, but I don't believe there is a way for the package tool to complete this?

@jesweene
Copy link
Contributor Author

@v-maheshbh when I test deploying the connector locally I get this error initially: image it seems like the way that package tool combines the contents in /Data Connectors/Anvilogic_CCF that there's a race condtion or an order of operation issuer where the DCR is created before the table? I was able to previously solve this by creating the table at install of the CCF solution, but I don't believe there is a way for the package tool to complete this?

if I attempt to connect the DataConnector a second time it works because the table creation was invoked the first time when it failed.

…Duration values — these fields are case-sensitive and should remain lowercase (e.g., 5m, 5h) to ensure proper functionality.
@jesweene
Copy link
Contributor Author

jesweene commented Aug 28, 2025

@v-maheshbh you should have contributor access

Added '6ccc187a-42ee-4635-8bcc-3b299f8570df' to the SkipIdValidationsTemplates.json file to exclude this template from ID change validations.
Eliminated an unnecessary trailing space from the 'alertDisplayNameFormat' field in mainTemplate.json to ensure consistent formatting of alert display names.
v-maheshbh
v-maheshbh previously approved these changes Aug 29, 2025
v-atulyadav
v-atulyadav previously approved these changes Aug 29, 2025
@v-maheshbh v-maheshbh dismissed stale reviews from v-atulyadav and themself via 82d2de0 September 1, 2025 04:23
@rahul0216 rahul0216 merged commit edddce7 into Azure:master Sep 1, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants