Conversation
|
This is related PR to #12572, when uploading the package we got validation errors While the solution was being submitted in the marketplace, we got the below validation errors Your code did not pass one or more of the best practice tests. Click on the PR link below to see details.
Can you please look into it. |
|
Hi @RamboV, |
Hi @v-shukore |
|
Hi @shubhamloginsoft, |
|
Hi @v-shukore I have updated the link. And yes both links are point to same Zip file. We have another Function App located under the playbook/CustomConnector folder. Please update the short link for this Function App as well. The GitHub links have already been updated in the README file. Let me know if you need any additional updates or input from my side. |
|
Hi @shubhamloginsoft, could you please share the URL here so we can create a short link for it as well? Thank you! |
Hi @v-shukore This is github url link for logic app custom connector(function app). |
|
Hi @shubhamloginsoft, here is the short link for the provided URL. Please update and commit the changes. |
@microsoft-github-policy-service agree @microsoft-github-policy-service agree company="VMRay" |
I have updated the url and also accept the CLA. Please let me know if anything required |
|
Hi @shubhamloginsoft, you have updated the short links in the maintemplate file, but not in the zip folder. The maintemplate and CreateUI files should be same both inside the zip and outside. please update the zip as well. Thanks! |
Hi @v-shukore Updated the zip as well. Thanks you. Please let me know if anything required. |
|
Hi @shubhamloginsoft, as I checked, the CreateUI looks as shown in the screenshot below. Please verify once. As per the requirements, if all updates have been completed, so we can proceed to review and merge this PR. |
Hi @v-shukore looks good. Please proceed with further process. |




Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.