Skip to content

Updated Release notes#12891

Merged
v-atulyadav merged 10 commits intoAzure:masterfrom
shubhamloginsoft:shubhamloginsoft-patch-1
Oct 13, 2025
Merged

Updated Release notes#12891
v-atulyadav merged 10 commits intoAzure:masterfrom
shubhamloginsoft:shubhamloginsoft-patch-1

Conversation

@shubhamloginsoft
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@shubhamloginsoft shubhamloginsoft requested review from a team as code owners September 29, 2025 10:39
@v-shukore v-shukore self-assigned this Sep 29, 2025
@RamboV
Copy link
Contributor

RamboV commented Sep 29, 2025

This is related PR to #12572, when uploading the package we got validation errors

While the solution was being submitted in the marketplace, we got the below validation errors

Your code did not pass one or more of the best practice tests. Click on the PR link below to see details.
You must add the GUID f1de974b-f438-4719-b423-8bf704ba2aef as one of your search keywords.
The package name (3.0.0) and package version (1.0.0) should match. It should be 3.0.0.
The links are not working

Can you please look into it.

@v-shukore
Copy link
Contributor

Hi @RamboV,
This solution includes two Azure deploy files. To ensure each file can be referenced individually, you will need to create two separate shortlinks one for each file.
image
Thanks!

@shubhamloginsoft
Copy link
Contributor Author

Hi @RamboV, This solution includes two Azure deploy files. To ensure each file can be referenced individually, you will need to create two separate shortlinks one for each file. image Thanks!

Hi @v-shukore
I have updated the github link. Please review and let me know if anything needed.
Please update the shortlink accordingly.

@v-shukore
Copy link
Contributor

Hi @shubhamloginsoft,
Please update the shortlink and ensure the description is formatted correctly so the author can easily distinguish between the two files. please find below links -
https://aka.ms/sentinel-VMRay-azuredeployflex
https://aka.ms/sentinel-VMRay-azuredeploypremium
Additionally, could you please confirm whether both URLs point to the same ZIP file?
Thanks!

@shubhamloginsoft
Copy link
Contributor Author

https://aka.ms/sentinel-VMRay-azuredeploypremium

Hi @v-shukore I have updated the link. And yes both links are point to same Zip file.

We have another Function App located under the playbook/CustomConnector folder. Please update the short link for this Function App as well. The GitHub links have already been updated in the README file.

Let me know if you need any additional updates or input from my side.

@v-shukore
Copy link
Contributor

Hi @shubhamloginsoft, could you please share the URL here so we can create a short link for it as well? Thank you!

@shubhamloginsoft
Copy link
Contributor Author

Hi @shubhamloginsoft, could you please share the URL here so we can create a short link for it as well? Thank you!

Hi @v-shukore
https://github.com/Azure/Azure-Sentinel/raw/refs/heads/master/Solutions/VMRay/Playbooks/CustomConnector/VMRayEnrichment_FunctionAppConnector/VMRayEnrichment.zip

This is github url link for logic app custom connector(function app).

@v-shukore
Copy link
Contributor

Hi @shubhamloginsoft, here is the short link for the provided URL. Please update and commit the changes.
Additionally, kindly accept CLA.
https://aka.ms/sentinel-VMRay-Enrichment
Thanks!

@shubhamloginsoft
Copy link
Contributor Author

shubhamloginsoft commented Oct 10, 2025

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree company="VMRay"

@shubhamloginsoft
Copy link
Contributor Author

Hi @shubhamloginsoft, here is the short link for the provided URL. Please update and commit the changes. Additionally, kindly accept CLA. https://aka.ms/sentinel-VMRay-Enrichment Thanks!

I have updated the url and also accept the CLA. Please let me know if anything required

@v-shukore
Copy link
Contributor

Hi @shubhamloginsoft, you have updated the short links in the maintemplate file, but not in the zip folder. The maintemplate and CreateUI files should be same both inside the zip and outside. please update the zip as well. Thanks!

@shubhamloginsoft
Copy link
Contributor Author

Hi @shubhamloginsoft, you have updated the short links in the maintemplate file, but not in the zip folder. The maintemplate and CreateUI files should be same both inside the zip and outside. please update the zip as well. Thanks!

Hi @v-shukore Updated the zip as well. Thanks you. Please let me know if anything required.

@v-shukore
Copy link
Contributor

Hi @shubhamloginsoft, as I checked, the CreateUI looks as shown in the screenshot below. Please verify once. As per the requirements, if all updates have been completed, so we can proceed to review and merge this PR.
image

@shubhamloginsoft
Copy link
Contributor Author

Hi @shubhamloginsoft, as I checked, the CreateUI looks as shown in the screenshot below. Please verify once. As per the requirements, if all updates have been completed, so we can proceed to review and merge this PR. image

Hi @v-shukore looks good. Please proceed with further process.

@v-atulyadav v-atulyadav merged commit 10c6056 into Azure:master Oct 13, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants