Skip to content

Conversation

@v-sabiraj
Copy link
Contributor

@v-sabiraj v-sabiraj commented Oct 23, 2025

Required items, please complete

Change(s):

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-sabiraj v-sabiraj requested review from a team as code owners October 23, 2025 09:09
@v-shukore v-shukore added the Solution Solution specialty review needed label Oct 23, 2025
@v-shukore v-shukore self-assigned this Oct 23, 2025
@v-sabiraj v-sabiraj requested a review from Copilot October 23, 2025 09:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Sophos Endpoint Protection solution from version 3.0.5 to 3.0.6, implementing improvements to the data connector configuration and parameter handling.

Key changes:

  • Version number updated across all relevant files from 3.0.5 to 3.0.6
  • Enhanced data connector configuration with new parameters (guidValue, innerWorkspace) and parameter type changes for improved security
  • Added "kind": null properties to workspace table definitions
  • Updated parameter casing for ClientId/ClientSecret references to maintain consistency

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
Solutions/Sophos Endpoint Protection/Package/mainTemplate.json Updated solution version, modified data connector parameters structure, added kind property to tables, and fixed parameter reference casing
Solutions/Sophos Endpoint Protection/Package/createUiDefinition.json Updated data connector description text to include "(using REST API)" specification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@v-sabiraj v-sabiraj merged commit f28cff2 into master Oct 23, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants