-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Replace TimeGenerated with EventEndTime in KQL queries for Box workbook #13037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Box solution workbook to use EventEndTime instead of TimeGenerated for time-based filtering in KQL queries, aligning with the standardized time field from the CCP (Codeless Connector Platform) data connector. The changes also include version bumps and metadata updates to reflect this modification.
- Updated all KQL queries in the Box workbook to filter and aggregate on
EventEndTimeinstead ofTimeGenerated - Incremented solution version from 3.1.1 to 3.1.2
- Updated workbook version from 1.0.0 to 1.0.1
- Modified data connector dependency from
BoxDataConnectortoBoxEventsCCPDefinition
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Workbooks/WorkbooksMetadata.json | Updated workbook version, data type dependency from BoxEvents_CL to BoxEvents, and connector dependency |
| Solutions/Box/Workbooks/Box.json | Replaced all TimeGenerated references with EventEndTime in KQL queries throughout the workbook |
| Solutions/Box/ReleaseNotes.md | Added entry documenting the KQL query updates for version 3.1.2 |
| Solutions/Box/Package/mainTemplate.json | Updated solution version, workbook version, descriptions, and CCP data connector template parameters |
| Solutions/Box/Package/createUiDefinition.json | Updated data connector text to reference "Box Events (CCP)" |
| Solutions/Box/Package/3.1.2.zip | Added packaged solution file for new version |
| Solutions/Box/Data/Solution_Box.json | Incremented solution version to 3.1.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "tokenEndpointQueryParameters": { | ||
| "box_subject_type": "enterprise", | ||
| "box_subject_id": "[[parameters('boxEnterpriseId')]" | ||
| "box_subject_id": "{{boxEnterpriseId}}" |
Copilot
AI
Oct 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent parameter reference syntax. This uses mustache-style {{boxEnterpriseId}} while the rest of the ARM template uses bracket notation [[parameters('boxEnterpriseId')]. ARM templates should consistently use bracket notation for parameter references, not mustache syntax.
| "box_subject_id": "{{boxEnterpriseId}}" | |
| "box_subject_id": "[parameters('boxEnterpriseId')]" |
|
Rule creation fail for : |
|
@v-sabiraj, Getting similar error for Hunting query as well. Seems like, have to update the Time generated column with updated one |
|
Hello how are you I am GitHub bot |
Thanks @v-sudkharat , fixed both Analytic rules and Hunting queries. Thanks. |
v-sudkharat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated changes looks Good
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.