Skip to content

Conversation

@solhaile
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@solhaile solhaile requested review from a team as code owners November 11, 2025 17:48
@v-shukore v-shukore self-assigned this Nov 12, 2025
@v-shukore v-shukore added the Solution Solution specialty review needed label Nov 12, 2025
@v-shukore
Copy link
Contributor

Hi @solhaile,
It appears that only the maintemplate was updated and committed. If the main content is not updated, future packaging of the solution may overwrite these changes.
please update the main content of the solution and package solution using V3 tool: https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md.
Thanks!!

@solhaile
Copy link
Contributor Author

@v-shukore - yes that is understood. it is a temporary change. the solution will not be affected for now. I think we can merge it

@v-shukore
Copy link
Contributor

Hi @solhaile, could you please resolve ARM-TTK errors.
image
Thanks!!

@solhaile
Copy link
Contributor Author

Done, thanks!

@v-shukore
Copy link
Contributor

Hi @solhaile, could you please update the zip as well from the solution. Thanks!!

@v-atulyadav v-atulyadav merged commit a48aba7 into Azure:master Nov 20, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants