Skip to content

Conversation

@srikarshastry
Copy link

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@srikarshastry srikarshastry requested review from a team as code owners November 12, 2025 20:09
@srikarshastry
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

Copy link
Contributor

@jlheard jlheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a query window of 5 minutes acceptable with CrowdStrike's rate limiting threshold and the rate limit QPS set to 1?

@srikarshastry
Copy link
Author

Is a query window of 5 minutes acceptable with CrowdStrike's rate limiting threshold and the rate limit QPS set to 1?

query window is increased to 15mins with rate limit to 1 => 1 request per second per data type which is within limits as compared to 10. This change is more of a try and error approach because crowdstrike sets rate limits for each tenant based on their cogs and config. In our internal testing for 12 hours, we haven't seen a single 429 exception

@v-shukore v-shukore added the Solution Solution specialty review needed label Nov 13, 2025
@v-shukore v-shukore assigned v-atulyadav and unassigned v-maheshbh Nov 13, 2025
@hassanchawiche hassanchawiche merged commit 985ee4c into Azure:master Nov 13, 2025
32 checks passed
@srikarshastry srikarshastry deleted the feature/srsistla/crowdstrikeApi branch December 9, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants