-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Ermes Browser Security integration 3.1.0 #13303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ermes Browser Security integration 3.1.0 #13303
Conversation
- configurable API url - fixed timestamp extraction and request configuration (time range and sorting) - expanded collected fields to include log_data (for relevant event categories)
@microsoft-github-policy-service agree company="Ermes Cyber Security S.p.A." |
|
Hi @lmoretto Thanks! |
Hi @v-maheshbh, regarding
Are you suggesting I should rename already existing files? |
Yes, the file names need to be renamed. Thanks! |
Ok thanks, will do! Regarding version number
To better understand your request, why can't we use 3.1.0? According to semver, this is not just a fix version, as it changes the output table schema to add an additional field and also updates configuration UI to support an additional optional api url parameter. A minor version bump would seem like the most correct change. |
Okay..Please proceed using version 3.1.0. Thanks! |
|
Hi @v-maheshbh, Thanks for your review, I've just pushed the requested changes. Below you can find the screenshots for the connection UI. |
|
Hi @lmoretto Thanks! |
Thanks! |
Hi @v-maheshbh , Is this screenshot ok or should I provide something different? Thanks! |
|
Hi @v-maheshbh, thanks for approving this PR! When can we expect this to be merged so that we can submit our updated marketplace offer for review to be published in Content Hub? |





Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: